Skip to content

fs: preserve negative utimes timestamps #64627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GiHoon1123 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

fs: preserve negative utimes timestamps #64627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/internal/fs/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const {
ArrayIsArray,
BigInt,
Date,
DateNow,
DatePrototypeGetTime,
ErrorCaptureStackTrace,
FunctionPrototypeCall,
Expand Down Expand Up @@ -786,9 +785,6 @@ function toUnixTimestamp(time, name = 'time') {
return +time;
}
if (NumberIsFinite(time)) {
if (time < 0) {
return DateNow() / 1000;
}
return time;
}
if (isDate(time)) {
Expand Down
9 changes: 6 additions & 3 deletions test/parallel/test-fs-utimes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function stat_resource(resource, statSync = fs.statSync) {
}

function check_mtime(resource, mtime, statSync) {
mtime = fs._toUnixTimestamp(mtime);
mtime = getExpectedMtime(mtime);
const stats = stat_resource(resource, statSync);
const real_mtime = fs._toUnixTimestamp(stats.mtime);
return mtime - real_mtime;
Expand All @@ -64,14 +64,17 @@ function expect_ok(syscall, resource, err, atime, mtime, statSync) {
assert(
// Check up to single-second precision.
// Sub-second precision is OS and fs dependent.
!err && (mtime_diff < 2) || err && err.code === 'ENOSYS',
!err && (Math.abs(mtime_diff) < 2) || err && err.code === 'ENOSYS',
`FAILED: expect_ok ${util.inspect(arguments)}
check_mtime: ${mtime_diff}`
);
}

function getExpectedMtime(mtime) {
// Negative numeric timestamps are normalized to "now" at call time.
// Keep negative numeric timestamps so the test catches normalization to now.
if (typeof mtime === 'number' && mtime < 0) {
return mtime;
}
return fs._toUnixTimestamp(mtime);
}

Expand Down
Loading