Skip to content

benchmark: remove old alias usage in ffi benchmarks #63666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
addaleax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

benchmark: remove old alias usage in ffi benchmarks #63666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/ffi/add-f64.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
ensureFixtureLibrary();

const { lib, functions } = ffi.dlopen(libraryPath, {
add_f64: { result: 'f64', parameters: ['f64', 'f64'] },
add_f64: { result: 'f64', arguments: ['f64', 'f64'] },
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be return df09b2a#diff-58e332998f95a4eba485ff5fcee1e396ae23b1ac86d099926cd23d12995ba0dcL129-L132

Suggested change
add_f64: { result: 'f64', arguments: ['f64', 'f64'] },
add_f64: { return: 'f64', arguments: ['f64', 'f64'] },

});

const add = functions.add_f64;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/ffi/add-i32.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
ensureFixtureLibrary();

const { lib, functions } = ffi.dlopen(libraryPath, {
add_i32: { result: 'i32', parameters: ['i32', 'i32'] },
add_i32: { result: 'i32', arguments: ['i32', 'i32'] },
});

const add = functions.add_i32;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/ffi/getpid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
});

const { lib, functions } = ffi.dlopen(null, {
uv_os_getpid: { result: 'i32', parameters: [] },
uv_os_getpid: { result: 'i32', arguments: [] },
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uv_os_getpid: { result: 'i32', arguments: [] },
uv_os_getpid: { return: 'i32', arguments: [] },

});

const getpid = functions.uv_os_getpid;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/ffi/many-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
ensureFixtureLibrary();

const { lib, functions } = ffi.dlopen(libraryPath, {
sum_6_i32: { result: 'i32', parameters: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] },
sum_6_i32: { result: 'i32', arguments: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] },
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sum_6_i32: { result: 'i32', arguments: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] },
sum_6_i32: { return: 'i32', arguments: ['i32', 'i32', 'i32', 'i32', 'i32', 'i32'] },

});

const fn = functions.sum_6_i32;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/ffi/pointer-bigint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const bench = common.createBenchmark(main, {
ensureFixtureLibrary();

const { lib, functions } = ffi.dlopen(libraryPath, {
pointer_to_usize: { result: 'u64', parameters: ['pointer'] },
pointer_to_usize: { result: 'u64', arguments: ['pointer'] },
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pointer_to_usize: { result: 'u64', arguments: ['pointer'] },
pointer_to_usize: { return: 'u64', arguments: ['pointer'] },

});

const fn = functions.pointer_to_usize;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/ffi/sum-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, {
ensureFixtureLibrary();

const { lib, functions } = ffi.dlopen(libraryPath, {
sum_buffer: { result: 'u64', parameters: ['pointer', 'u64'] },
sum_buffer: { result: 'u64', arguments: ['pointer', 'u64'] },
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sum_buffer: { result: 'u64', arguments: ['pointer', 'u64'] },
sum_buffer: { return: 'u64', arguments: ['pointer', 'u64'] },

});

function main({ n, size }) {
Expand Down
Loading