Skip to content

src: remove redundant handle_ field in ffi#63665

Open
addaleax wants to merge 1 commit into
nodejs:mainfrom
addaleax:ffi-no-extra-handle-field
Open

src: remove redundant handle_ field in ffi#63665
addaleax wants to merge 1 commit into
nodejs:mainfrom
addaleax:ffi-no-extra-handle-field

Conversation

@addaleax
Copy link
Copy Markdown
Member

This was just a copy of the immediately preceding
handle_ field in uv_lib_t.

This was just a copy of the immediately preceding
`handle_` field in `uv_lib_t`.

Signed-off-by: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 30, 2026
@addaleax addaleax added the ffi Issues and PRs related to experimental Foreign Function Interface support. label May 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (17e4196) to head (2573814).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/node_ffi.cc 64.28% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63665   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files         732      732           
  Lines      236454   236455    +1     
  Branches    44540    44527   -13     
=======================================
+ Hits       213589   213612   +23     
+ Misses      14581    14543   -38     
- Partials     8284     8300   +16     
Files with missing lines Coverage Δ
src/node_ffi.h 61.53% <ø> (ø)
src/node_ffi.cc 69.95% <64.28%> (-0.10%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants