tools: use lts node in notify-on-push workflow#63084
Open
nsinfoPRO wants to merge 1 commit intonodejs:mainfrom
Open
tools: use lts node in notify-on-push workflow#63084nsinfoPRO wants to merge 1 commit intonodejs:mainfrom
nsinfoPRO wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
MikeMcC399
reviewed
May 2, 2026
Comment on lines
+10
to
+12
| env: | ||
| NODE_VERSION: lts/* | ||
|
|
Contributor
There was a problem hiding this comment.
This wouldn't be correct, as this environment variable would be provided by the parent repo.
I suggest that you leave a PR to a member of the organization who has write access to the repo. That is the reason that I did not submit a PR.
MikeMcC399
reviewed
May 2, 2026
Contributor
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
As I wrote in #63070 I didn't submit a PR myself because I don't have write access to the repo.
You also don't have write access, and you have never committed to the repo previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without pinning Node.js, the runner defaults to Node 20 and npx falls back to
core-validate-commit@5.0.1instead of6.0.0(requires Node 22+). Version 5 doesn't recognise theffisubsystem, causing false invalid-commit alerts.Fixes: #63070