Skip to content

stream: avoid constructing extra promise in createPromiseCallback #63064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aduh95 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Draft

stream: avoid constructing extra promise in createPromiseCallback #63064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67d1e1e
stream: avoid extra promise allocation in `createPromiseCallback`
aduh95 May 1, 2026
55bde30
fixup! stream: avoid extra promise allocation in `createPromiseCallback`
aduh95 May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/internal/per_context/primordials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ const {
ArrayPrototypePushApply,
ArrayPrototypeSlice,
FinalizationRegistry,
FunctionPrototypeBind,
FunctionPrototypeCall,
Map,
ObjectDefineProperties,
Expand Down Expand Up @@ -435,6 +436,12 @@ const SafePromise = makeSafe(
class SafePromise extends Promise {},
);

{
// eslint-disable-next-line node-core/prefer-primordials
const OriginalPromiseTry = Promise.try;
primordials.BindPromiseTry = (fn) => FunctionPrototypeBind(OriginalPromiseTry, Promise, fn);
}

/**
* Attaches a callback that is invoked when the Promise is settled (fulfilled or
* rejected). The resolved value cannot be modified from the callback.
Expand Down
5 changes: 3 additions & 2 deletions lib/internal/webstreams/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ const {
ArrayPrototypePush,
ArrayPrototypeShift,
AsyncIteratorPrototype,
BindPromiseTry,
FunctionPrototypeBind,
MathMax,
NumberIsNaN,
PromisePrototypeThen,
ReflectApply,
ReflectGet,
Symbol,
Uint8Array,
Expand Down Expand Up @@ -164,7 +165,7 @@ function enqueueValueWithSize(controller, value, size) {

function createPromiseCallback(name, fn, thisArg) {
validateFunction(fn, name);
return async (...args) => ReflectApply(fn, thisArg, args);
return BindPromiseTry(thisArg === undefined ? fn : FunctionPrototypeBind(fn, thisArg));
}

function isPromisePending(promise) {
Expand Down
Loading