Skip to content

lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array #63017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array #63017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ class ReadableStreamBYOBRequest {

/**
* @readonly
* @type {ArrayBufferView}
* @type {Uint8Array}
Copy link
Copy Markdown
Member

@jazelly jazelly May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking - but looks like this can technically be null from the implementation

node/lib/internal/webstreams/readablestream.js

Line 2667 in 13e90d0

controller[kState].byobRequest[kState].view = null;

Copy link
Copy Markdown
Contributor

@MattiasBuelens MattiasBuelens May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, although that only happens after you've already responded to the BYOB request. From MDN:

null if the request has already been responded to, by calling ReadableStreamBYOBRequest.respond() or ReadableStreamBYOBRequest.respondWithNewView().

*/
get view() {
if (!isReadableStreamBYOBRequest(this))
Expand Down
Loading