Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/internal/util/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -2198,10 +2198,16 @@ function formatNumber(fn, number, numericSeparator) {
}

const numberString = String(number);

// Scientific notation cannot have numeric separators applied sensibly
if (StringPrototypeIncludes(numberString, 'e')) {
return fn(numberString, 'number');
}

const integer = MathTrunc(number);

if (integer === number) {
if (!NumberIsFinite(number) || StringPrototypeIncludes(numberString, 'e')) {
if (!NumberIsFinite(number)) {
return fn(numberString, 'number');
}
return fn(addNumericSeparator(numberString), 'number');
Expand Down
37 changes: 37 additions & 0 deletions test/parallel/test-util-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -3846,6 +3846,43 @@ assert.strictEqual(
}
}

// Regression test for https://github.com/nodejs/node/issues/62981
// numericSeparator should not corrupt scientific notation numbers
{
// Test cases from the bug report
assert.strictEqual(
util.inspect(1e-7, { numericSeparator: true }),
'1e-7'
);
assert.strictEqual(
util.inspect(1.23e-7, { numericSeparator: true }),
'1.23e-7'
);
assert.strictEqual(
util.inspect(1.23e+7, { numericSeparator: true }),
'1.23e+7'
);
assert.strictEqual(
util.inspect(-1.23e-7, { numericSeparator: true }),
'-1.23e-7'
);
assert.strictEqual(
util.inspect(1e10, { numericSeparator: true }),
'1e10'
);
assert.strictEqual(
util.inspect(1.2345678901234567e+20, { numericSeparator: true }),
'1.2345678901234567e+20'
);

// With default numericSeparator: true
const { numericSeparator } = util.inspect.defaultOptions;
util.inspect.defaultOptions.numericSeparator = true;
assert.strictEqual(util.inspect(1e-7), '1e-7');
assert.strictEqual(util.inspect(1.5e-10), '1.5e-10');
util.inspect.defaultOptions.numericSeparator = numericSeparator;
}

// Regression test for https://github.com/nodejs/node/issues/41244
{
assert.strictEqual(util.inspect({
Expand Down