Skip to content

lib: insert argv[0] at argv[1] in setDeserializeMainFunction#62928

Open
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:snapshot-des
Open

lib: insert argv[0] at argv[1] in setDeserializeMainFunction#62928
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:snapshot-des

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Apr 24, 2026

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem. labels Apr 24, 2026
@watilde watilde requested a review from joyeecheung April 24, 2026 14:57
@watilde watilde changed the title snapshot: insert argv[0] at argv[1] in setDeserializeMainFunction lib: insert argv[0] at argv[1] in setDeserializeMainFunction Apr 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (2428030) to head (3f12b2c).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62928      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.01%     
==========================================
  Files         706      706              
  Lines      219219   219219              
  Branches    42004    42002       -2     
==========================================
- Hits       196499   196483      -16     
- Misses      14622    14636      +14     
- Partials     8098     8100       +2     
Files with missing lines Coverage Δ
lib/internal/v8/startup_snapshot.js 95.38% <100.00%> (ø)

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 24, 2026
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 module Issues and PRs related to the "v8" subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants