crypto: reject duplicate ML-KEM JWK key_ops#62905
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 25, 2026
Merged
crypto: reject duplicate ML-KEM JWK key_ops#62905nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62905 +/- ##
==========================================
- Coverage 91.43% 89.62% -1.82%
==========================================
Files 356 706 +350
Lines 150580 219201 +68621
Branches 23602 41989 +18387
==========================================
+ Hits 137686 196449 +58763
- Misses 12625 14629 +2004
- Partials 269 8123 +7854
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Apr 24, 2026
Collaborator
ChALkeR
reviewed
Apr 24, 2026
ChALkeR
approved these changes
Apr 24, 2026
Member
Author
That's the nature of depending on formats that are meant to be extensible. If this was rejecting unrecognized you couldn't evolve the JWK format with additional ops. Not that key_ops in JWK is ever used in practice though. It's an annoyance. The "use" parameter or better yet an explicit "alg" is more than enough. |
Collaborator
|
Landed in 8f348bc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this in #62706. Web Cryptography JWK import must reject duplicate entries in the JWK's
key_ops.