Skip to content

test: update expectations for OpenSSL 3.6 and OpenSSL 4.0#62805

Open
panva wants to merge 8 commits intonodejs:mainfrom
panva:test-fixup-openssl-4
Open

test: update expectations for OpenSSL 3.6 and OpenSSL 4.0#62805
panva wants to merge 8 commits intonodejs:mainfrom
panva:test-fixup-openssl-4

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 18, 2026

Followup to #62410, this PR updates test expectations for OpenSSL 4.0 (and in one case for OpenSSL 3.6).

Tested with a temporary shared openssl workflow in #62799 (https://github.com/nodejs/node/actions/runs/24604775004)

Closes #62799
Closes #60088
Closes #62817

panva added 8 commits April 18, 2026 15:35
TLS_server_method() was added in OpenSSL 1.1.0.

All version-specific methods were deprecated in OpenSSL 1.1.0.

All version-specific methods were removed in OpenSSL 4.0.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva requested a review from richardlau April 18, 2026 13:57
@panva panva added tls Issues and PRs related to the tls subsystem. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 18, 2026
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. labels Apr 18, 2026
Copy link
Copy Markdown
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (64b3e83) to head (4f3785f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62805      +/-   ##
==========================================
- Coverage   89.69%   89.67%   -0.03%     
==========================================
  Files         706      706              
  Lines      218270   218288      +18     
  Branches    41782    41775       -7     
==========================================
- Hits       195786   195758      -28     
- Misses      14390    14446      +56     
+ Partials     8094     8084      -10     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 18, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@nodejs-github-bot

This comment was marked as outdated.

@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 18, 2026

Note for whoever lands this: I think affcd80 fixes #60088

@panva
Copy link
Copy Markdown
Member Author

panva commented Apr 18, 2026

Note for whoever lands this: I think affcd80 fixes #60088

Indeed it does. Thank you.

@nodejs-github-bot

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it does fix #60088

I was not able to build with OpenSSL 4.0.0 (error below) but that's not related to this PR, I'm getting the same on main.

Details
Undefined symbols for architecture arm64:
  "_ENGINE_by_id", referenced from:
      ncrypto::EnginePointer::getEngineByName(char const*, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_ctrl_cmd_string", referenced from:
      ncrypto::EnginePointer::getEngineByName(char const*, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_finish", referenced from:
      ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::reset(engine_st*, bool) in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::operator=(ncrypto::EnginePointer&&) in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_free", referenced from:
      ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::reset(engine_st*, bool) in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::~EnginePointer() in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::operator=(ncrypto::EnginePointer&&) in libncrypto.a(ncrypto.engine.o)
      ncrypto::EnginePointer::getEngineByName(char const*, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_init", referenced from:
      ncrypto::EnginePointer::init(bool) in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_load_builtin_engines", referenced from:
      ncrypto::EnginePointer::initEnginesOnce() in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_load_private_key", referenced from:
      ncrypto::EnginePointer::loadPrivateKey(char const*) in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_register_all_complete", referenced from:
      ncrypto::EnginePointer::initEnginesOnce() in libncrypto.a(ncrypto.engine.o)
  "_ENGINE_set_default", referenced from:
      ncrypto::EnginePointer::setAsDefault(unsigned int, ncrypto::CryptoErrorList*) in libncrypto.a(ncrypto.engine.o)
  "_SSL_CTX_set_client_cert_engine", referenced from:
      node::crypto::SecureContext::SetClientCertEngine(v8::FunctionCallbackInfo<v8::Value> const&) in libnode.a(libnode.crypto_context.o)
ld: symbol(s) not found for architecture arm64

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@Renegade334 Renegade334 linked an issue Apr 19, 2026 that may be closed by this pull request
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[openssl-4.0.0] - failing tests parallel/test-tls-ocsp-callback fails with OpenSSL 3.6.0

4 participants