stream: fix nested compose error propagation by mcollina · Pull Request #62556 · nodejs/node

mcollina · 2026-04-02T05:41:53Z

nodejs-github-bot · 2026-04-02T05:41:59Z

Review requested:

@nodejs/streams

codecov · 2026-04-02T07:03:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.79%. Comparing base (449a93a) to head (efff997).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62556      +/-   ##
==========================================
+ Coverage   89.78%   89.79%   +0.01%     
==========================================
  Files         697      697              
  Lines      215749   215770      +21     
  Branches    41294    41298       +4     
==========================================
+ Hits       193705   193748      +43     
+ Misses      14124    14119       -5     
+ Partials     7920     7903      -17

Files with missing lines	Coverage Δ
lib/internal/streams/duplexify.js	`96.91% <100.00%> (+0.34%)`	⬆️
lib/internal/streams/from.js	`86.75% <100.00%> (+1.18%)`	⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

test/parallel/test-stream-readable-compose.js

lib/internal/streams/duplexify.js

Add eslint-disable-line require-yield for generator that intentionally doesn't yield (throws error instead). Add __proto__: null in duplexify.js object literal as suggested by reviewer.

Add eslint-disable-line require-yield for generator that intentionally doesn't yield (throws error instead). Add __proto__: null in duplexify.js object literal as suggested by reviewer. Use yield* source instead of for-await loop in second transform.

mcollina · 2026-04-07T07:03:32Z

@benjamingr @aduh95 ptal

nodejs-github-bot · 2026-04-07T21:04:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72546/

nodejs-github-bot · 2026-04-08T17:34:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/62556
✔  Done loading data for nodejs/node/pull/62556
----------------------------------- PR info ------------------------------------
Title      stream: fix nested compose error propagation (#62556)
Author     Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch     mcollina:fix-compose-60083 -> nodejs:main
Labels     stream, needs-ci, commit-queue-squash
Commits    2
 - stream: fix nested compose error propagation
 - stream: apply review comments from #62556
Committers 1
 - Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/62556
Fixes: https://github.com/nodejs/node/issues/60083
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62556
Fixes: https://github.com/nodejs/node/issues/60083
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 02 Apr 2026 05:41:53 GMT
   ✔  Approvals: 3
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/62556#pullrequestreview-4048503631
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/62556#pullrequestreview-4061335051
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/62556#pullrequestreview-4067613763
   ✘  GitHub CI failed with status: FAILURE
   ℹ  Last Full PR CI on 2026-04-07T21:04:02Z: https://ci.nodejs.org/job/node-test-pull-request/72546/
- Querying data for job/node-test-pull-request/72546/
✔  Build data downloaded
- Querying failures of job/node-test-commit/86842/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/24149403948

nodejs-github-bot · 2026-04-08T19:30:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72569/

nodejs-github-bot · 2026-04-14T10:03:26Z

Commit Queue failed

- Loading data for nodejs/node/pull/62556
✔  Done loading data for nodejs/node/pull/62556
----------------------------------- PR info ------------------------------------
Title      stream: fix nested compose error propagation (#62556)
Author     Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch     mcollina:fix-compose-60083 -> nodejs:main
Labels     stream, needs-ci, commit-queue-squash
Commits    2
 - stream: fix nested compose error propagation
 - stream: apply review comments from #62556
Committers 1
 - Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/62556
Fixes: https://github.com/nodejs/node/issues/60083
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62556
Fixes: https://github.com/nodejs/node/issues/60083
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 02 Apr 2026 05:41:53 GMT
   ✔  Approvals: 3
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/62556#pullrequestreview-4048503631
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/62556#pullrequestreview-4061335051
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/62556#pullrequestreview-4067613763
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-08T19:30:39Z: https://ci.nodejs.org/job/node-test-pull-request/72569/
- Querying data for job/node-test-pull-request/72569/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62556
From https://github.com/nodejs/node
 * branch                  refs/pull/62556/merge -> FETCH_HEAD
✔  Fetched commits as d0fa608c0796..efff997289ad
--------------------------------------------------------------------------------
Auto-merging lib/internal/streams/duplexify.js
[main ac1ba34242] stream: fix nested compose error propagation
 Author: Matteo Collina <hello@matteocollina.com>
 Date: Wed Apr 1 20:29:57 2026 +0200
 3 files changed, 50 insertions(+), 9 deletions(-)
Auto-merging lib/internal/streams/duplexify.js
[main 0d659555f4] stream: apply review comments from #62556
 Author: Matteo Collina <hello@matteocollina.com>
 Date: Mon Apr 6 09:58:12 2026 +0000
 2 files changed, 3 insertions(+), 5 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting to fixup everything into first commit.
[main 19f79fcff7] stream: fix nested compose error propagation
 Author: Matteo Collina <hello@matteocollina.com>
 Date: Wed Apr 1 20:29:57 2026 +0200
 3 files changed, 48 insertions(+), 9 deletions(-)
--------------------------------- New Message ----------------------------------
PR-URL: https://github.com/nodejs/node/pull/62556
Fixes: https://github.com/nodejs/node/issues/60083
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[main cbed3cc266] PR-URL: https://github.com/nodejs/node/pull/62556 Fixes: https://github.com/nodejs/node/issues/60083 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
 Author: Matteo Collina <hello@matteocollina.com>
 Date: Wed Apr 1 20:29:57 2026 +0200
 3 files changed, 48 insertions(+), 9 deletions(-)
  ✖  cbed3cc266632ab36b3d93bc516a7be85f247d84
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:7      Valid fixes URL.                          fixes-url
     ✖  1:0      blank line expected after title           line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✖  0:0      Commit must have a PR-URL.                pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✖  0:0      Invalid subsystem: "PR-URL"               subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✔  0:0      Title is <= 50 columns.                   title-length
   ℹ  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`

https://github.com/nodejs/node/actions/runs/24392862567

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Apr 2, 2026

ronag approved these changes Apr 2, 2026

View reviewed changes

aduh95 reviewed Apr 2, 2026

View reviewed changes

test/parallel/test-stream-readable-compose.js Outdated Show resolved Hide resolved

aduh95 reviewed Apr 2, 2026

View reviewed changes

test/parallel/test-stream-readable-compose.js Show resolved Hide resolved

aduh95 reviewed Apr 2, 2026

View reviewed changes

lib/internal/streams/duplexify.js Outdated Show resolved Hide resolved

mcollina force-pushed the fix-compose-60083 branch from 32916e9 to 608b639 Compare April 6, 2026 07:20

benjamingr approved these changes Apr 6, 2026

View reviewed changes

mcollina force-pushed the fix-compose-60083 branch from 8c64fb7 to 8f4657c Compare April 6, 2026 09:58

mcollina added 2 commits April 6, 2026 21:52

stream: fix nested compose error propagation

25ae47b

mcollina force-pushed the fix-compose-60083 branch from 8f4657c to efff997 Compare April 6, 2026 21:52

jasnell approved these changes Apr 7, 2026

View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 7, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 8, 2026

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 14, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2026

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stream: fix nested compose error propagation#62556

stream: fix nested compose error propagation#62556
mcollina wants to merge 2 commits intonodejs:mainfrom
mcollina:fix-compose-60083

mcollina commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 8, 2026

Uh oh!

nodejs-github-bot commented Apr 8, 2026

Uh oh!

nodejs-github-bot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

mcollina commented Apr 2, 2026

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

codecov bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 7, 2026

Uh oh!

nodejs-github-bot commented Apr 8, 2026

Uh oh!

nodejs-github-bot commented Apr 8, 2026

Uh oh!

nodejs-github-bot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Apr 2, 2026 •

edited

Loading