Conversation
|
Review requested:
|
|
cc: @nodejs/tsc since itβs an end-of-life deprecation |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60658 +/- ##
=======================================
Coverage 89.62% 89.63%
=======================================
Files 706 704 -2
Lines 219136 219113 -23
Branches 41987 41980 -7
=======================================
- Hits 196404 196398 -6
- Misses 14611 14614 +3
+ Partials 8121 8101 -20
π New features to boost your workflow:
|
|
cc @nodejs/crypto @nodejs/net |
|
It looks flaky in GitHub Actions CI. Could someone rerun it, please? |
|
Should I do a rebase to see if itβs still failing? |
That wouldn't help (unless a fix for the flakiness had landed on main since last commit, but AFAIK that's not the case), and force us to re-review and re-run all CI jobs |
Commit Queue failed- Loading data for nodejs/node/pull/60658 β Done loading data for nodejs/node/pull/60658 ----------------------------------- PR info ------------------------------------ Title tls: move _tls_* to end-of-life (#60658) Author Sebastian Beltran <bjohansebas@gmail.com> (@bjohansebas) Branch bjohansebas:tls_eol -> nodejs:main Labels tls, c++, semver-major, author ready, deprecations, needs-ci, needs-citgm Commits 1 - tls: move _tls_* to end-of-life Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Sun, 09 Nov 2025 21:40:41 GMT β Approvals: 2 β - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/60658#pullrequestreview-3597808519 β - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-3613841924 β semver-major requires at least 2 TSC approvals β Last GitHub CI successful βΉ Last Full PR CI on 2025-12-20T16:15:00Z: https://ci.nodejs.org/job/node-test-pull-request/70556/ - Querying data for job/node-test-pull-request/70556/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21187285768 |
|
Note that these weren't runtime-deprecated in 24, only in 25. |
|
If the intention is for this to make the v26 cut, this should be rebased and CI re-run. |
|
@nodejs/tsc please review :), i need one more approval for land this, because it's a major changes |
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Fast-track has been requested by @bjohansebas. Please π to approve. |
So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.