fix: initialize selected submodules for Undici CITGM - #1115
Open
mcollina wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
- Coverage 96.50% 96.33% -0.17%
==========================================
Files 29 29
Lines 2203 2213 +10
==========================================
+ Hits 2126 2132 +6
- Misses 77 81 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Undici CITGM failure reported in nodejs/undici#5642.
CITGM's Undici lookup entry runs
test:cache-tests, but the normal GitHub source archive does not contain the contents of thetest/fixtures/cache-testssubmodule. Use a shallow Git clone and initialize only that required submodule. Avoid initializing the WPT submodule, which is unnecessarily large and is not run by this entry.This adds a
submoduleslookup option for selecting submodules whenuseGitCloneis enabled.Tests
npm test