fix unsafe integer strings getting rounded#22
Open
cbartondock wants to merge 1 commit intonode-steam:masterfrom
Open
fix unsafe integer strings getting rounded#22cbartondock wants to merge 1 commit intonode-steam:masterfrom
cbartondock wants to merge 1 commit intonode-steam:masterfrom
Conversation
…> 18446744073709552000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a string like "18446744073709551615" gets converted to a rounded integer 18446744073709552000
Valve in fact uses extremely long numerical game ids, so this is an issue SRM has been seeing. Should be fixed herein.
Also kind of addresses issue #12 since it just leaves unsafe integers as strings, which is much better than rounding them.