test: handle null-prototype json fields#1080
Merged
tunnckoCore merged 1 commit intomasterfrom Apr 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this was breaking
PR #1066 changed parsed
fields/filesobjects to useObject.create(null)to avoid prototype clobbering.test/integration/json.test.jswas still comparing the returnedfieldsvalue against a plain object literal withassert.deepStrictEqual(). That assertion checks prototypes too, so the test failed even though the printed contents looked identical.The thrown assertion then prevented the test from reaching
res.end(),server.close(), anddone(), which is why Jest also reported a timeout.Fix
Object.getPrototypeOf(fields) === null{ ...fields }to the expected plain object contents