Skip to content

[C-Api] release allocated data #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaeyun-jung wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[C-Api] release allocated data #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion c/src/ml-api-common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ _ml_tensors_data_destroy_internal (ml_tensors_data_h data, gboolean free_data)
status);
}
} else {
for (i = 0; i < ML_TENSOR_SIZE_LIMIT; i++) {
for (i = 0; i < _data->num_tensors; i++) {
g_clear_pointer (&_data->tensors[i].data, g_free);
}
}
Expand Down Expand Up @@ -772,6 +772,11 @@ _ml_tensors_data_create_no_alloc (const ml_tensors_info_h info,

g_mutex_init (&_data->lock);

/**
* We now release allocated data only when _ml_tensors_data_destroy_internal() is called.
* Be careful, if you update the number of tensors after creating the data handle,
* you should manage the memories with changed index.
*/
_info = (ml_tensors_info_s *) info;
if (_info != NULL) {
status = _ml_tensors_info_create_from (info, &_data->info);
Expand Down
Loading