Language negotiation for service and collection metadata - #214
Open
jampukka wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks! Suggested configuration model, negotiation implementation and localization of descriptive elements seems to be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve #197
.propertiesfile declared withlocale.<lang>.path, holdingonly the keys that differ from the base config
Localizationgets its values from here, falling back to the base configper key, so a catalog can be arbitrarily sparse and a declared language
needs no catalog at all
LocalizableKeysdescribes the allowed keys a catalog file can override, extraneous keys will throw an exceptionLocalizationLangNegotiation?lang=andAccept-LanguageLocalizableKeysLocalizedFeatureServiceConfig/LocalizedFeatureTypeLocalization), delegates every other method to wrapped Config/FeatureType.