extensive update to TBB functionality to extend/fix (replaces PR #171)#209
Open
paciorek wants to merge 60 commits into
Open
extensive update to TBB functionality to extend/fix (replaces PR #171)#209paciorek wants to merge 60 commits into
paciorek wants to merge 60 commits into
Conversation
- handling user-defined reduction functions - error-trapping non-user defined invalid reduction functions - setting default init values - fixing up handling of inf and negative init values - allowing a user to specify the reduction fun as char or actual function.
…ts are contained in private, and packaged names can be managed (#125) * initial redesign of nClass to hold a private Cpublic_obj and use it by active bindings * Add basic nClass_uncompiled tests * major work towards redesigning nClass generation and hierarchy * fix C++ handling (Exporter and generic interface set) of new nClass structure * close to finished with updated class naming issues within packages * updated tests after new packingNames and nCompile naming schemes * update predefineds. fix nimbleModels. fix package class generation with R fields. * fix StridedTensorMap operator() for single index * fix cpp_tests crash * test trials * give each case in test-argumentPassing unique package naming * Fix test-tensorCreation for old style
Also handle missing shareVars or copyVars args.
Also handle use of external object in parallel_for.
parallel_loop_body cases a unique ID. This addresses problems with different parfors in different methods of a class.
- allow multiple parallel_reduce operations - handle local method as the reduction operator.
- use without assignment or in return() - use in return() - multiple calls to parallel_reduce at same level of AST.
Start on setting number of threads.
Finalize parallel_reduce tests.
Put counting into class constructor/destructor.
- handling user-defined reduction functions - error-trapping non-user defined invalid reduction functions - setting default init values - fixing up handling of inf and negative init values - allowing a user to specify the reduction fun as char or actual function.
Also handle use of external object in parallel_for.
parallel_loop_body cases a unique ID. This addresses problems with different parfors in different methods of a class.
- allow multiple parallel_reduce operations - handle local method as the reduction operator.
- use without assignment or in return() - use in return() - multiple calls to parallel_reduce at same level of AST.
Start on setting number of threads.
Finalize parallel_reduce tests.
This passes `*this` as is also done when a member method is used without `self`. It also flags if `self` is used in the body by replacing with `liftedSelf` and modifying C++ generation to use `obj__.` instead of `(this)->`.
…ly as oopposed to one by one.
Somehow we reverted some of the changes made in PR #140. This goes back to what we did in that PR.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a large body of work to flesh out TBB functionality. Since
tbbbranch had diverged a lot frommainand a test merge was crazily messy, I did a rebase.I also then manually merged in the work on the issue of nested calls to setting the number of TBB threads (issue #152 , PR #178 which became PR #188, both now closed).