Initialize zipcmp entries before cleanup - #558
Open
soul-sol wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zipcmparchive entry before assigning metadataextra_fieldspointerlist_zip()allocates its entry array withmalloc(). In the normal non-paranoid path it setsn_extra_fieldsto zero but leavesextra_fieldsuninitialized.archive_deinit()later callsentry_deinit(), which unconditionally frees that pointer.The existing
entry_init()helper already establishes the complete ownership state, so calling it before populating an entry fixes the invalid free without changing comparison behavior.Verification
zipcmp_zip_dir.testandzipcmp_zip_dir_slash.testabort under ASan inarchive_deinit -> entry_deinit -> free.zip_read_fuzzer,zip_read_metadata_fuzzer, andzip_read_file_fuzzer; zero sanitizer failures.Build flags: