Skip to content

Add nitlsconfig to optional gRPC dependencies - #2205

Merged
ni-jfitzger merged 2 commits into
ni:masterfrom
robinMadriaga-NI:users/rmadriag/add_nitlsconfig_dep
Aug 25, 2026
Merged

Add nitlsconfig to optional gRPC dependencies#2205
ni-jfitzger merged 2 commits into
ni:masterfrom
robinMadriaga-NI:users/rmadriag/add_nitlsconfig_dep

Conversation

@robinMadriaga-NI

Copy link
Copy Markdown
Contributor

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Adds nitlsconfig[grpc]>=1.0.0a1 to the optional dependencies of gRPC-capable nimi-python driver packages, enabling applications to create NI-TLS-configured TLS/mTLS channels for CRA readiness and pass them to the existing GrpcSessionOptions API.

The shared package template and generated setup.py files are updated together. Existing gRPC APIs and caller-provided secure or insecure channels remain unchanged.

What testing has been done?

  • Verified all nitlsconfig-python has been added to optional grpc packages in setup.py files

  • Built a local nidmm wheel from this branch and verified that nidmm[grpc] installs nitlsconfig==1.0.0a1 from production PyPI.

@codecov-commenter

codecov-commenter commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.70%. Comparing base (b6458aa) to head (ace9595).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   88.69%   88.70%           
=======================================
  Files          59       59           
  Lines       18722    18722           
=======================================
+ Hits        16606    16607    +1     
+ Misses       2116     2115    -1     
Flag Coverage Δ
nidcpowersystemtests 94.38% <ø> (+0.04%) ⬆️
nidigitalsystemtests 92.02% <ø> (ø)
nidmmsystemtests 92.29% <ø> (ø)
nifgensystemtests 94.32% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nirfsasystemtests 82.66% <ø> (ø)
nirfsgsystemtests 81.12% <ø> (ø)
niscopesystemtests 89.96% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.56% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6458aa...ace9595. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger

Copy link
Copy Markdown
Collaborator

Do you plan to follow this up with any unit or system tests?

@robinMadriaga-NI

Copy link
Copy Markdown
Contributor Author

Do you plan to follow this up with any unit or system tests?

Yes. Follow-up work is tracked by AB#3913710. We plan to add nimi-python CI coverage for secure gRPC mTLS channel creation. And then updating the driver specific nimi-python ATS events

Comment thread build/templates/setup.py.mako

@ni-jfitzger ni-jfitzger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, unit tests and other CI checks are not currently running.
We only have system testing, until #2201 goes in.
This looks okay, though.

@ni-jfitzger
ni-jfitzger merged commit 4f7d249 into ni:master Aug 25, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants