Add nitlsconfig to optional gRPC dependencies - #2205
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2205 +/- ##
=======================================
Coverage 88.69% 88.70%
=======================================
Files 59 59
Lines 18722 18722
=======================================
+ Hits 16606 16607 +1
+ Misses 2116 2115 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Do you plan to follow this up with any unit or system tests? |
Yes. Follow-up work is tracked by AB#3913710. We plan to add nimi-python CI coverage for secure gRPC mTLS channel creation. And then updating the driver specific nimi-python ATS events |
ni-jfitzger
left a comment
There was a problem hiding this comment.
FYI, unit tests and other CI checks are not currently running.
We only have system testing, until #2201 goes in.
This looks okay, though.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Adds
nitlsconfig[grpc]>=1.0.0a1to the optional dependencies of gRPC-capable nimi-python driver packages, enabling applications to create NI-TLS-configured TLS/mTLS channels for CRA readiness and pass them to the existingGrpcSessionOptionsAPI.The shared package template and generated
setup.pyfiles are updated together. Existing gRPC APIs and caller-provided secure or insecure channels remain unchanged.What testing has been done?
Verified all nitlsconfig-python has been added to optional grpc packages in setup.py files
Built a local
nidmmwheel from this branch and verified thatnidmm[grpc]installsnitlsconfig==1.0.0a1from production PyPI.