feat: nginx loadbalancing validation

[buchdag]

No description provided.

[Copilot]

Pull request overview

Adds validation and normalization for NGINX load-balancing directives.

Changes:

• Implements parsers for supported load-balancing methods.
• Adds table-driven parser tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
internal/template/nginx_validation.go	Adds load-balancing validation logic.
internal/template/nginx_validation_test.go	Tests accepted and rejected directives.

Suppressed comments (1)

internal/template/nginx_validation.go:112

• The NGINX hash directive requires a key (hash key [consistent]), so accepting the one-element case returns a bare hash directive that NGINX will reject when validating the generated configuration. Return an error when the key is missing and update the test that currently accepts this input.

	case 1:
		// no parameters

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

internal/template/nginx_validation.go:91

• nginxMustParseLoadbalance uses strings.Split(value, " ") without trimming/field-normalizing first. This mis-parses directives with multiple spaces/tabs or leading/trailing whitespace (creating empty elements) and also prevents hash keys containing spaces from reaching nginxQuote as a single parameter (e.g. hash foo bar{} becomes 3 tokens and is rejected). Consider trimming first, using strings.Fields for method selection, and preserving the full remainder string for the hash key (with optional trailing consistent).

func nginxMustParseLoadbalance(value string) (string, error) {
	value = strings.TrimSuffix(value, ";")
	methodAndParameters := strings.Split(value, " ")
	method := strings.TrimSpace(methodAndParameters[0])

internal/template/nginx_validation_test.go:188

• The new load-balance parser tests don’t cover common whitespace normalization cases (leading/trailing whitespace, multiple spaces) or a hash key containing spaces (which the implementation intends to support via nginxQuote). Adding a couple of cases here would help prevent regressions in the tokenizer/normalization logic.

		{
			name:      "trailing semicolon is normalized",
			input:     "least_conn;",
			wantValue: "least_conn",
		},