Skip to content

Remove docker.io in container address#518

Merged
JoseEspinosa merged 5 commits into
nf-core:devfrom
CarineRey:patch-1
Jul 15, 2026
Merged

Remove docker.io in container address#518
JoseEspinosa merged 5 commits into
nf-core:devfrom
CarineRey:patch-1

Conversation

@CarineRey

@CarineRey CarineRey commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Remove docker.io in container address as in commit fa3221e for modules/local/multiqc_custom_peaks.nf for charliecloud compatibility

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

@CarineRey
Remove docker.io in container address
7c3acb8 
Remove docker.io in container address as in commit fa3221e for modules/local/multiqc_custom_peaks.nf
for charliecloud compatibility
JoseEspinosa
JoseEspinosa reviewed Jun 30, 2026
View reviewed changes

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CarineRey for your contribution and sorry for the late reply!
Would you mind fixing the conflict, the issue is that the main.nf should be moved from modules/local/annotate_boolean_peaks.nf to modules/local/annotate_boolean_peaks/main.nf, also would be great if you could update the changelog.
Thanks!

JoseEspinosa
JoseEspinosa requested changes Jul 15, 2026
View reviewed changes

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the URL of the image should be fixed and then test should pass

Comment thread modules/local/annotate_boolean_peaks/main.nf Outdated
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d5e1a7a

+| ✅ 271 tests passed       |+
#| ❔   5 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   8 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config
  • files_unchanged - File ignored due to lint config: assets/nf-core-chipseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-chipseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-07-15 08:34:58

JoseEspinosa
JoseEspinosa approved these changes Jul 15, 2026
View reviewed changes

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks

@JoseEspinosa JoseEspinosa merged commit d453ef8 into nf-core:dev Jul 15, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CarineRey @JoseEspinosa