Skip to content

Remove smart picker dialog from text - #9040

Open
xhon-pelushi wants to merge 2 commits into
nextcloud:mainfrom
xhon-pelushi:fix/text-7795-inline-smart-picker
Open

Remove smart picker dialog from text#9040
xhon-pelushi wants to merge 2 commits into
nextcloud:mainfrom
xhon-pelushi:fix/text-7795-inline-smart-picker

Conversation

@xhon-pelushi

Copy link
Copy Markdown

Fixes #7795

Fixes nextcloud#7795

Signed-off-by: xhon-pelushi <xhon@pelushi.com>

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xhon-pelushi

Thanks a lot for your contribution. Could you add some screenshots to illustrate the effective change in the UI? That will make the design review easier.

The failing static analysis test is unrelated. You do not need to worry about that.

@xhon-pelushi

Copy link
Copy Markdown
Author

Thanks @max-nextcloud — happy to add screenshots. Summary of the UI change while I gather them:

Before: choosing a smart-picker result could open an extra dialog layer on top of the editor.
After: the smart picker stays inline in the editor flow (no separate dialog), matching the issue goal of removing the smart picker dialog from Text.

I'll follow up with before/after screenshots as soon as I can capture them from a running instance.

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@xhon-pelushi

Copy link
Copy Markdown
Author

Thanks @max-nextcloud — before/after screenshots for the smart picker UX change:

Before (blocking dialog via getLinkWithPicker):

Smart picker dialog

After (inline / menu — same path as typing slash in the editor):

Inline smart picker menu

Static HTML repros rendered with headless Chromium; code change removes the dialog call and focuses the editor with / instead. Can remove pr-screenshots/ before merge if preferred.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove smart picker dialog from text

2 participants