Fixing Message Input Regression - Message draft saved on orientation change - #6413
Fixing Message Input Regression - Message draft saved on orientation change#6413rapterjet2004 wants to merge 2 commits into
Conversation
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/29355879831/artifacts/8321365575 |
mahibi
left a comment
There was a problem hiding this comment.
tested and it still fails most of the time. The input field is empty after rotation.
Also it happened one time that an prior text was shown after rotation while i expected it to be a newer one as i updated it meanwhile.
I think it's worth it to take a close look if the entire draft implementation is done in a best way.
|
I remember fixing a bug like this before, but it seems like the draft functionality regressed. I'd say it's a good opportunity for a significant refactor. Perhaps, with the new chat architecture, changing the source of truth should fix the bug and lead to a cleaner solution. |
867680b to
4b57907
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/31194265259/artifacts/9002240688 |
… unsynchronized state bug moving away from vanniktech emoji picker Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
9a669e7 to
2b6a20f
Compare
mahibi
left a comment
There was a problem hiding this comment.
@rapterjet2004 i see you reintroduced an emoji picker with this branch.
While i personally agree using the google emojipicker makes sense in the message input panel and the implementation looks quite nice, could you please extract this to a different pull request so there is one topic per pull request and we an discuss in a separate PR if it should be included?
As seen in #2735 there are different opinions regarding the emojipicker without a search feature..
Reintroducing the emoji picker was out of scope for this message draft refactor; also fixes a leftover restoreState() call that no longer resolved after the draft state rename to initInputState(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/32867219252/artifacts/9571748219 |
Screen_recording_20260807_111005.webm
🚧 TODO
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)