Fix: Make case-insensitive search for the usergroup and multi selection columns#2446
Open
Koc wants to merge 1 commit into
Open
Fix: Make case-insensitive search for the usergroup and multi selection columns#2446Koc wants to merge 1 commit into
Koc wants to merge 1 commit into
Conversation
Koc
force-pushed
the
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
branch
from
a3b8def to
120718e
Compare
enjeck
reviewed
Apr 11, 2026
Koc
force-pushed
the
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
branch
from
120718e to
fe95c8c
Compare
Koc
force-pushed
the
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
branch
4 times, most recently
from
c1e07dc to
b342f82
Compare
enjeck
requested changes
Jun 27, 2026
| const filterValue = (filter.magicValuesEnriched ? filter.magicValuesEnriched : filter.value).toLowerCase() | ||
| const cellLabel = this.getLabel(cell.value)?.toLowerCase() | ||
| const filterMethod = { | ||
| [FilterIds.ContainsItem]() { return filterValue.map(option => option.id).includes(cell.value) }, |
Contributor
There was a problem hiding this comment.
ContainsItem crashes on Selection / SelectionMulti
- Create a table with a single-selection column and add a few rows.
- On that column open the filter menu and pick the operator "Is one of" / "Contains item" (the one that shows option chips, FilterIds.ContainsItem).
- Select one option and apply.
- Fails to create view
Contributor
Author
There was a problem hiding this comment.
aah, good catch 🦅
Fixed now and thanx for clear reproducer.
Koc
force-pushed
the
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
branch
from
b342f82 to
b2edadc
Compare
…on columns Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
bugfix/make-usergroup-selection-milti-filters-case-insensetiv
branch
from
b2edadc to
28efb9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for the #1798. It spreads same logic what we have in text line type to other column types. So, now everything is case insensitive.
It also fixes filters for usergroup single selection
🔘 Single selection
☑️ Multi selection
👤 User single selection
👥 User multi selection