fix: use cloneDeep for proxy objects#18436
Merged
Merged
Conversation
Contributor
Author
|
/backport to stable34 |
nickvergessen
approved these changes
Jun 25, 2026
ShGKme
reviewed
Jun 25, 2026
Comment on lines
+226
to
+227
| const config = structuredClone(object.config) | ||
| const config = structuredClone(toRaw(object.config)) |
Contributor
There was a problem hiding this comment.
Importing Vue and having a reactive object is unexpected in capabilities manager to me. Does it actually happen?
Contributor
Author
There was a problem hiding this comment.
No, it's a plain object (though it's nested)
| */ | ||
| function createCombinedSystemMessage({ id, messages, type, collapsed }) { | ||
| const combinedMessage = structuredClone(messages[0]) | ||
| const combinedMessage = structuredClone(toRaw(messages[0])) |
Contributor
There was a problem hiding this comment.
If the message isn't a flat object, we need either recursive toRaw or cloneDeep from es-toolkit.
Contributor
Author
There was a problem hiding this comment.
extra 3.5 kB, doesn't sound bad
- structuredClone() can not be called on Proxy - es-toolkit adds 3.5 kB to size Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/str-clone-proxy
branch
from
6e91d7d to
8294fb4
Compare
Antreesy
changed the title
ShGKme
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
lodashwithes-toolkit#15377structuredClone()can not be called on Proxy, so target should be converted to a plain object firstAI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist