fix(dashboard): update scrollbar contrast on background#62244
Open
kristian-zendato wants to merge 1 commit into
Open
fix(dashboard): update scrollbar contrast on background#62244kristian-zendato wants to merge 1 commit into
kristian-zendato wants to merge 1 commit into
Conversation
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
kristian-zendato
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
joshtrichards
added
bug
3. to review
joshtrichards
changed the title
| #content { | ||
| overflow: auto; | ||
| /* Scrollbar sits on the background image — use plain-text color for contrast */ | ||
| scrollbar-color: var(--color-background-plain-text) transparent; |
Member
There was a problem hiding this comment.
I'm not sure this is versatile enough for all possible backgrounds: e.g. high-contrast themes, custom background images, or maintaining contrast along the entire scrollbar edge of an arbitrary image. Part of the approach used for the dashboard #header might be applicable/re-usable.
Author
There was a problem hiding this comment.
@joshtrichards Thank you for the comment.
Dashboard Header always uses --color-background-plain-text which I used for the scrollbar.
Also I tried with different scenarios, custom background images and colors and high-contrast themes, it works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)