Skip to content

fix(files_version): mtime confusion on milliseconds#62204

Open
blizzz wants to merge 2 commits into
masterfrom
fix/noid/version-mtime-confusion
Open

fix(files_version): mtime confusion on milliseconds#62204
blizzz wants to merge 2 commits into
masterfrom
fix/noid/version-mtime-confusion

Conversation

@blizzz

@blizzz blizzz commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

When the Version tab is open and a file is edited, the previews were broken, and so was the download link for the current version. The reason is that the server reports a timestamp on seconds granularity, while JS in the frontend has it on milliseconds level. Zeroing them out solves the issue.

Before After
before.webm after.webm

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@blizzz blizzz added this to the Nextcloud 35 milestone Jul 15, 2026
@blizzz blizzz requested a review from susnux July 15, 2026 21:18
@blizzz blizzz requested a review from a team as a code owner July 15, 2026 21:18
@blizzz blizzz added the bug label Jul 15, 2026
@blizzz blizzz requested review from nfebe and sorbaugh and removed request for a team July 15, 2026 21:18
@blizzz blizzz added 3. to review Waiting for reviews feature: versions labels Jul 15, 2026
@blizzz blizzz force-pushed the fix/noid/version-mtime-confusion branch from c5eee63 to 9049315 Compare July 15, 2026 21:30

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to find a better way :/

Comment thread apps/files_versions/src/views/FilesVersionsSidebarTab.vue Outdated
@blizzz blizzz force-pushed the fix/noid/version-mtime-confusion branch from 9049315 to cb68c7c Compare July 16, 2026 14:05
blizzz added 2 commits July 16, 2026 16:07
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/noid/version-mtime-confusion branch from cb68c7c to 7ed47b2 Compare July 16, 2026 14:10
@blizzz blizzz requested a review from susnux July 16, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants