fix(files): sync sidebar route on open#60719
Open
hweihwang wants to merge 1 commit into
Open
Conversation
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
fix/files-sidebar-active-folder-route
branch
from
218bdbc to
163e1c0
Compare
hweihwang
requested review from
nfebe and
sorbaugh
and removed request for
a team
susnux
reviewed
May 25, 2026
| logger.debug('sidebar: already open for current node - switching tab', { tabId }) | ||
| setActiveTab(tabId) | ||
| } | ||
| updateOpenRoute(node) |
Contributor
There was a problem hiding this comment.
Why are those changes needed? The fileid should already be handled by the active store?
So the watcher here should properly trigger the opendetails query?
susnux
reviewed
May 25, 2026
Comment on lines
+316
to
+319
| // if we just loaded the app. | ||
| const node = (this.currentFolder?.fileid === fileId | ||
| ? this.currentFolder | ||
| : this.nodes.find((n) => n.fileid === fileId)) as INode | undefined |
Contributor
There was a problem hiding this comment.
It seems like this is enough to fix the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileidto the node being opened while addingopendetails=true.opendetailsroute handling to resolve the current folder, not only cached child rows.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
Verification
/index.php/apps/files/files/1681?dir=/p9697460, breadcrumbp9697460> Share reopened childc9697460; URL stayed on1681&opendetails=true.p9697460> Share opened parentp9697460; URL changed to/index.php/apps/files/files/1680?dir=/p9697460&opendetails=true./index.php/apps/files/files/1680?dir=/p9697460&opendetails=trueopened the parent sidebar.npm run buildinbuild/frontend-legacy; only existing asset-size warnings. Generateddist/output was not committed.git diff --check HEAD~1..HEADpassed.