Skip to content

[stable32] feat(files_external): convert to delegated settings#59869

Draft
backportbot[bot] wants to merge 4 commits into
stable32from
backport/59001/stable32
Draft

[stable32] feat(files_external): convert to delegated settings#59869
backportbot[bot] wants to merge 4 commits into
stable32from
backport/59001/stable32

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Apr 23, 2026

Backport of #59001

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot Bot requested review from artonge and leftybournes April 23, 2026 07:31
@backportbot backportbot Bot added this to the Nextcloud 32.0.9 milestone Apr 23, 2026
@tanyaka tanyaka force-pushed the backport/59001/stable32 branch 7 times, most recently from 886009a to ea56014 Compare May 19, 2026 08:59
@tanyaka
Copy link
Copy Markdown
Contributor

tanyaka commented May 19, 2026

/compile

@tanyaka tanyaka force-pushed the backport/59001/stable32 branch 3 times, most recently from 8dd08c7 to 256a539 Compare May 20, 2026 08:56
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you make sure that comments are also backported?

For the psalm issue, you can run: composer psalm -- --set-baseline to add the new error to the psalm baseline.

@tanyaka tanyaka force-pushed the backport/59001/stable32 branch 2 times, most recently from 051a773 to 7b86c49 Compare May 21, 2026 08:45
@tanyaka
Copy link
Copy Markdown
Contributor

tanyaka commented May 21, 2026

Looks good. Can you make sure that comments are also backported?

For the psalm issue, you can run: composer psalm -- --set-baseline to add the new error to the psalm baseline.

Thank you for re-check! I've updated psalm baseline. But don't get what do you mean with "comments" to be backported?

@artonge
Copy link
Copy Markdown
Collaborator

artonge commented May 21, 2026

But don't get what do you mean with "comments" to be backported?

The initial PR contains comments that are not present in this backport.

@tanyaka
Copy link
Copy Markdown
Contributor

tanyaka commented May 21, 2026

But don't get what do you mean with "comments" to be backported?

The initial PR contains comments that are not present in this backport.

Sorry, don't get what you mean. Could you link the comments that you mean, please?

@artonge
Copy link
Copy Markdown
Collaborator

artonge commented May 22, 2026

Just one example: image

@tanyaka tanyaka force-pushed the backport/59001/stable32 branch from 7b86c49 to 960d3cb Compare May 22, 2026 12:02
tanyaka added 3 commits May 22, 2026 14:06
Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
…Controller

Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
…rs/groups

Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
@tanyaka tanyaka force-pushed the backport/59001/stable32 branch from 960d3cb to 732a4f9 Compare May 22, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants