Skip to content

Fix horizontal grid jumping on lazy load in Vue VirtualList #59549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RicoUHD wants to merge 4 commits into
base: master
Choose a base branch
from
+14 −11
Open

Fix horizontal grid jumping on lazy load in Vue VirtualList #59549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a5ebb3
Fix grid jumping left horizontally on lazy load in Vue VirtualList
RicoUHD Apr 9, 2026
e781fd9
Merge pull request #1 from RicoUHD/fix-files-grid-jump-99197273217025…
RicoUHD Apr 9, 2026
c1f6c78
Merge branch 'nextcloud:master' into master
RicoUHD Apr 9, 2026
6ce0d8f
Change justify-content from space-around to start
RicoUHD Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files/src/components/FilesListVirtual.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ export default defineComponent({

align-content: center;
align-items: center;
justify-content: space-around;
justify-content: start;
justify-items: center;

tr {
Expand Down
23 changes: 13 additions & 10 deletions apps/files/src/components/VirtualList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ import type { PropType } from 'vue'

import debounce from 'debounce'
import { defineComponent } from 'vue'
import { useFileListWidth } from '../composables/useFileListWidth.ts'
import { logger } from '../utils/logger.ts'

interface RecycledPoolItem {
Expand Down Expand Up @@ -131,11 +130,7 @@ export default defineComponent({
},

setup() {
const { width: fileListWidth } = useFileListWidth()

return {
fileListWidth,
}
return {}
},

data() {
Expand All @@ -145,6 +140,7 @@ export default defineComponent({
footerHeight: 0,
headerHeight: 0,
tableHeight: 0,
listWidth: 0,
resizeObserver: null as ResizeObserver | null,
}
},
Expand Down Expand Up @@ -197,10 +193,10 @@ export default defineComponent({
* 1 for list view otherwise depending on the file list width.
*/
columnCount(): number {
if (!this.gridMode) {
if (!this.gridMode || this.listWidth === 0) {
return 1
}
return Math.floor(this.fileListWidth / this.itemWidth)
return Math.floor(this.listWidth / this.itemWidth)
},

/**
Expand Down Expand Up @@ -269,10 +265,16 @@ export default defineComponent({
// The number of (virtual) rows below the currently rendered ones.
const rowsBelow = Math.max(0, this.totalRowCount - rowsAbove - this.rowCount)

return {
const style: Record<string, string> = {
paddingBlock: `${rowsAbove * this.itemHeight}px ${rowsBelow * this.itemHeight}px`,
minHeight: `${this.totalRowCount * this.itemHeight}px`,
}

if (this.gridMode) {
style.gridTemplateColumns = `repeat(${this.columnCount}, var(--row-width))`
}

return style
},
},

Expand Down Expand Up @@ -430,11 +432,12 @@ export default defineComponent({
},

/**
* Update the height variables.
* Update the height and width variables.
* To be called by resize observer and `onMount`
*/
updateHeightVariables(): void {
this.tableHeight = this.$el?.clientHeight ?? 0
this.listWidth = this.$el?.clientWidth ?? 0
this.beforeHeight = (this.$refs.before as HTMLElement)?.clientHeight ?? 0
this.footerHeight = (this.$refs.footer as HTMLElement)?.clientHeight ?? 0

Expand Down