fix(Util): getScripts also need to reorder core translations#59518
Open
fix(Util): getScripts also need to reorder core translations#59518
getScripts also need to reorder core translations#59518Conversation
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Currently `core-common` and `core-main` are prepanded to the scripts, as they provide the global state. But the script ordering logic does not know about this and might sort core translations after they are used. Meaning we need to register core translations as soon as the global scope is initialized (so that `OC.L10N.register` is available). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
provokateurin
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently
core-commonandcore-mainare prepended to the scripts, as they provide the global state. But the script ordering logic does not know about this and might sort core translations after they are used.Meaning we need to register core translations as soon as the global scope is initialized (so that
OC.L10N.registeris available).Checklist
3. to review, feature component)stable32)AI (if applicable)