fix: harden capabilities deserialization when sharing fields are missing#3166
Draft
joshtrichards wants to merge 2 commits intomainfrom
Draft
fix: harden capabilities deserialization when sharing fields are missing#3166joshtrichards wants to merge 2 commits intomainfrom
joshtrichards wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 17 complexity
Metric Results Complexity 17
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
|
APK file: https://github.com/nextcloud/notes-android/actions/runs/25006388550/artifacts/6665872202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
CapabilitiesDeserializerto safely handle partialfiles_sharingcapability payloads, especially when Share API or public sharing is disabled. Previously merged PR #2803 helped, but did not cover all edge cases.Changes
api_enabledas a gate for share-specific parsingfiles_sharingfields are always presentdefault_permissionsorpublic.passwordare missingdefault_permissionsederationWhy
The server can legitimately omit parts of
files_sharingdepending on configuration. The previous deserializer assumed those fields always existed, which could cause crashes during first-time account setup when Share API was disabled or when certain sharing options were turned off.Result
The app now tolerates partial sharing capability responses and falls back to the existing defaults in
Capabilitiesinstead of crashing.Closes #2815
Closes #3165
🖼️ Screenshots
🏁 Checklist