Fix SQLiteBlobTooBigException in note sync#3149
Open
utafrali wants to merge 1 commit intonextcloud:mainfrom
Open
Fix SQLiteBlobTooBigException in note sync#3149utafrali wants to merge 1 commit intonextcloud:mainfrom
utafrali wants to merge 1 commit intonextcloud:mainfrom
Conversation
The addNote() method was inserting notes and then immediately calling getNoteById() to fetch them back. With large content, this redundant fetch triggers SQLiteBlobTooBigException. Just set the ID directly on the note object and return it.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3148
The addNote() method was inserting notes and then immediately calling getNoteById() to fetch them back. With large content, this redundant fetch was triggering SQLiteBlobTooBigException.
Just set the ID on the note object directly and return it. No need for the extra database call.
Screenshots
N/A - backend fix only
Testing