feat(ui): fold the thread subject as the thread scrolls - #13543
Open
CreatorOfBiontium wants to merge 2 commits into
Open
feat(ui): fold the thread subject as the thread scrolls#13543CreatorOfBiontium wants to merge 2 commits into
CreatorOfBiontium wants to merge 2 commits into
Conversation
A long subject wrapped over several lines and pushed the message down, and the sticky header kept those lines on screen for the whole thread. Fold it to a single line as the thread scrolls instead, tied to the scroll position rather than to a timer, so that a reader who stops halfway finds it halfway. The header hands back the height the subject gives up. Without that, everything below moves up by as much on top of the scrolling that caused the fold, and the thread runs away from the finger; it also ties how fast the subject folds to how fast the thread moves, so neither can be chosen on its own. A line is measured in lh rather than --default-line-height, which the server sets to a bare ratio: subtracting it from a length voids the declaration it sits in, and the fold never ran at all. Scroll anchoring is off. The header changing height had the browser scroll back to compensate, which moved the thread over the mark that started the fold and unfolded it again, in a loop that got worse the longer the subject was. That loop is what sank the attempt in nextcloud#11754. The mobile offsets that compensated for the wrapping subject go with it, and the subject is indented past the back button that the app content lays over the header. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Tobiáš Vašťák <tobias.vastak@gmail.com>
CreatorOfBiontium
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
August 22, 2026 00:11
Signed-off-by: Tobiáš Vašťák <tobias.vastak@gmail.com>
Member
|
Thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...also known as the great revival of #11754 (by Claude)
As the title says, folds the thread subject on scroll so there's actually space for reading emails on phones/smaller displays.
🤖 AI (if applicable)