fix: review of OutOfOffice settings form - #13497
Open
madbob wants to merge 2 commits into
Open
Conversation
madbob
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
August 16, 2026 22:44
Contributor
|
Thanks, could you take a look at the conflicts?
Newlines are not working anymore |
Signed-off-by: Roberto Guido <info@madbob.org>
Signed-off-by: Roberto Guido <info@madbob.org>
Collaborator
Author
|
I've preferred to entirely drop plaintext/HTML/plaintext conversion, and just use the bare version of the string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Totally unrequested review of the OOO settings form, migrated to
Nc*components.Boldest changes:
TextEditorwith genericNcTextArea, applied because - after all - HTML editing was already disabled and it is not that differentthis.enabledwas tested as a boolean, while it is always a string), and my personal (and questionable!) opinion is that hiding unrequired components from the crowded settings panel helps in making it more readableFixes #9975