fix: validating email addresses from Contacts#13173
Open
madbob wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your PR 👍 Could you please fix the dco check? |
kesselb
approved these changes
Jun 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds an additional layer of recipient email validation when importing autocomplete suggestions from the Contacts app, preventing invalid contact email values (e.g., joe.com) from being offered as selectable recipients in the Mail composer.
Changes:
- Validate each Contacts-provided email address with
filter_var(..., FILTER_VALIDATE_EMAIL)before adding it as an autocomplete recipient.
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Contacts app now validates email addresses on his own (nextcloud/contacts#4380) so #7121 may be considered obsolete.
Yet, an extra check in
ContactsIntegrationmay prevent broken imports or other issues on the Contacts side.Fixes #7121