Chore(Documentation): Update metrics configuration in charts/nextcloud/README.md#870
Open
Tireur2cables wants to merge 2 commits into
Open
Chore(Documentation): Update metrics configuration in charts/nextcloud/README.md#870Tireur2cables wants to merge 2 commits into
Tireur2cables wants to merge 2 commits into
Conversation
…d/README.md Fix the values path for servicemonitor and add the new possible values for associated prometheus rules Signed-off-by: Nicolas Battaglini <43277447+Tireur2cables@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Nextcloud chart documentation to reflect the current values structure for Prometheus-related metrics resources, addressing the reported mismatch between chart behavior and README configuration keys.
Changes:
- Update ServiceMonitor configuration keys in the README from
metrics.serviceMonitor.*toprometheus.serviceMonitor.*. - Document PrometheusRule-related values under
prometheus.rules.*for exporter alerting/rules configuration. - Fix the metrics configuration table defaults/formatting for the ServiceMonitor labels entry.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds undocumented possible values and removes some unused values. Signed-off-by: Nicolas Battaglini <43277447+Tireur2cables@users.noreply.github.com>
Author
|
I am also wondering if I can remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix the values path for servicemonitor and add the new possible values for associated prometheus rules
Benefits
Documentation is more clear and reflect the real possible values.
Possible drawbacks
None that I know
Applicable issues
Additional information
No chart version bump needed I think as it is only documentation ?
Checklist
Chart.yamlaccording to semver.