Add export/import functionality for forms

[timedin-de]

building export and import via json
Download Button:

• fetches Forms Data (questions and settings, removes ids and hashes) => Downloads as json blob
• adds version of the app => on import, warn if downgrade
• modal to ask if answers should get exported as well? (!handle file uploads, not exported)

#1425

[codecov]

Codecov Report

❌ Patch coverage is 61.90476% with 16 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/Controller/ApiController.php	61.90%	16 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Chartman123]

@timedin-de Please don't merge the main branch into your branch, always rebase your's on main. Also please sign-off your commits.

[timedin-de]

@Chartman123 i dont think i did merge the main branch into mine, did sth slip through? Yes, will do, sorry for forgetting it everytime ^^

[Chartman123]

Now the history looks clean, don't now what it was then...

[Chartman123]

I've had a quick look at the PR and added a few comments :)

[timedin-de]

@Chartman123 i added the fixup commits for your comments, i'll rebase them if you accept them

One other thing I would improve is validation/sanitasation of import/export.

I'd make whitelist for allowed properties and remove others (or fail the request?) and copy the validations for questions: areExtraSettingsValid and array_search($type, Constants::ANSWER_TYPES)
and options:

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[Chartman123]

@timedin-de are you still working on this?

[timedin-de]

@timedin-de are you still working on this?

yes, im currently less active. Do you have any additions missing in this? And a decision for sanitazation?

[Chartman123]

And a decision for sanitazation?

I vote for the whitelist and throw an error if other properties are part of the request.

Do you have any additions missing in this?

No, don't think so :)

[Chartman123]

@timedin-de Did you merge main again? Please always use rebase... And can you please remove the issue id from the commit message? It creates a new log record on every push in the issue.

[timedin-de]

@timedin-de Did you merge main again? Please always use rebase... And can you please remove the issue id from the commit message? It creates a new log record on every push in the issue.

I'm sorry, i dont know what, but something got messed up while rebasing (promise, i didnt merge 😬 ) Now it should be clean.

Edit: it seems it messed up while doing the interactive rebase, I'll need to recheck the git docs on that.

[Chartman123]

I think you need to make sure that your forked main is up-to-date before doing the rebase :)

[timedin-de]

I think you need to make sure that your forked main is up-to-date before doing the rebase :)

thanks, yeah that and i ran git rebase -i HEAD~10 but should've git rebase -i main ^^

Now it should be clean