fix: clean up file shares on collaborator removal#3291
Merged
Chartman123 merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
pringelmann
added
3. to review
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
/backport to stable5.2 |
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
fix/cleanup-file-shares-on-removal-public
branch
from
d928241 to
2f52dc7
Compare
-e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
fix/cleanup-file-shares-on-removal-public
branch
from
2f52dc7 to
3ce7be0
Compare
Chartman123
approved these changes
Apr 14, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable5.2
git pull origin stable5.2
# Create the new backport branch
git checkout -b backport/3291/stable5.2
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 050c2b97 3ce7be05
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3291/stable5.2Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
pringelmann
added a commit
that referenced
this pull request
Apr 14, 2026
* fix(shares): clean up file shares on collaborator removal -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> * refactor(shares): fix TOCTOU in folder lookup -e Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a Forms collaborator share previously left the separate Files share for the uploaded response folder in place, so a removed collaborator kept read access to respondent uploads.