fix(governance): makes desktop UI closer to the files web UI

[mgallien]

Resolves

#

Summary

TODO

• ...

Checklist

• Sign-off message is added to all commits.
• The commit history is clean with no merge commits.
  • How to rebase your commits
  • How to squash commits with rebase
• Uploaded screenshots from before and after for UI changes.
• Test(s) added to branch, with before/after results included in PR description, for performance improvements where applicable.
• Documentation has been updated or is not required.
• Backports requested where applicable (critical bugfixes).
• Labels added where applicable (bug/enhancement).
• Milestone added for target version.

AI (if applicable)

• The content of this PR was partly or fully generated using AI
  • I have read the guidelines for AI-assisted contributions.
  • I have read Nextcloud's AI Contribution Policy.

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-10428.zip

Digest: sha256:51c9f964e7c00fe47dc3f298d0e3fae0a5f67fdc6acf557b517f7650a7531976

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

contextual menu on Dolphin

dialog when just opened

sensitivity selector open

"Apply" or "Reset" enabled due to pending changes

[mgallien]

@marcoambrosini @kra-mo apart from already provided (and not yet done) feedback
do you see anything else that could be changed or improved ?
as for the better selector, I will try to get it done asap in another PR

[sonarqubecloud]

Quality Gate failed

Failed conditions
19.6% Coverage on New Code (required ≥ 80%)
15.1% Duplication on New Code (required ≤ 3%)
36 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[i2h3]

@mgallien Looking at the opened list of options for the sensitivity label I feel a bit uncertain about the tick marks. Aren't the options mutually exclusive? Shouldn't it be then reflected better by option controls instead of checkboxes? The latter suggest multiple choice which does not make sense when looking at "Public" and "Internal".

[mgallien]

@mgallien Looking at the opened list of options for the sensitivity label I feel a bit uncertain about the tick marks. Aren't the options mutually exclusive? Shouldn't it be then reflected better by option controls instead of checkboxes? The latter suggest multiple choice which does not make sense when looking at "Public" and "Internal".

the logic of multiple or single selected label has been moved to the server app
clients should enable users to select labels and then apply them
server app is responsible to manage this to ensure, for example, that only one sensitivity label is selected

that said, the current UI component to select the labels is going to be replaced by a clone of the files web UI component