Skip to content

chore: cleanup some unused capability/sharing methods#10348

Merged
nilsding merged 3 commits into
masterfrom
refactor/noid/remove-unused-sharing-methods
Jul 13, 2026
Merged

chore: cleanup some unused capability/sharing methods#10348
nilsding merged 3 commits into
masterfrom
refactor/noid/remove-unused-sharing-methods

Conversation

@nilsding

Copy link
Copy Markdown
Member

extracted from #10307, each removal is in a separate commit

Checklist

AI (if applicable)

@nilsding nilsding added this to the 34.0.0 milestone Jul 10, 2026
@nilsding nilsding self-assigned this Jul 10, 2026
@nilsding

Copy link
Copy Markdown
Member Author

/backport to stable-34.0 please

@nilsding
nilsding force-pushed the refactor/noid/remove-unused-sharing-methods branch from 29128ac to b7817be Compare July 10, 2026 11:14

@mgallien mgallien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my question

Comment thread src/gui/socketapi/socketapi.cpp Outdated
@nilsding
nilsding force-pushed the refactor/noid/remove-unused-sharing-methods branch from b7817be to 441ffce Compare July 13, 2026 08:07
nilsding added 3 commits July 13, 2026 10:54
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
We use `label` for that

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding
nilsding enabled auto-merge July 13, 2026 08:55
@nilsding
nilsding force-pushed the refactor/noid/remove-unused-sharing-methods branch from 441ffce to cf6c0de Compare July 13, 2026 08:55
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10348.zip

Digest: sha256:5d6a3f157a479ff7837b83ffc28268a44c6dade8d0b995f036d5c8fd8a4c2eab

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding
nilsding merged commit 05493b2 into master Jul 13, 2026
21 checks passed
@nilsding
nilsding deleted the refactor/noid/remove-unused-sharing-methods branch July 13, 2026 09:53
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
79 New Code Smells (required ≤ 0)
D Security Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@mgallien mgallien modified the milestones: 34.0.0, 35.0.0 Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants