feat(card): show comments within the Details tab

[SadeqRouhani]

Remove the separate Comments sidebar tab and render the comment list and form at the bottom of the Details tab under a "Comments" heading, so a card's description and its discussion are visible together without switching tabs. The Activity tab moves up to fill the freed slot, and the comments badge on a card now opens the Details tab.

• Resolves: #
• Target version: main

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required

[grnd-alt]

thanks for your contribution! we should discuss this some more so here are some screenshots as a basis.
I personally have my doubts about this change as it can clutter the main tab more, especially if the descriptions get long, getting to comments might be an issue?

I saw some other issues where both @marcoambrosini and @jancborchardt commented on this issue, (marco really seems to have wanted this change: #5396) so maybe you can give your approval if you still think this should happen?

in the sidebar:

in the modal:

[putt1ck]

Personally I'd think comments should be above the description; people already familiar with the card will just be interested in the latest comments and want the fastest turnaround, people arriving there for the first time can scroll down and read the description then read up through the comment timeline to see if their own questions/thoughts have already been added by someone else. If the description is at the top and a viewer can then immediately add a comment they may well be repeating something already address in the existing comments that they haven't scrolled through.

[grnd-alt]

people already familiar with the card will just be interested in the latest comments and want the fastest turnaround, people arriving there for the first time can scroll down and read the description

so description first -> long scrolling to get to comments, comments first -> long scrolling to get to description,
to me that sounds like one click to get to the comments tab is the easier variant, for both types of users.

If the description is at the top and a viewer can then immediately add a comment they may well be repeating something already address in the existing comments that they haven't scrolled through.

we basically already have the same issue now, I think that's a different topic.

[putt1ck]

One click on the card or one click on the link letting you know about the new comment - gets you to the card, a second click gets you to comment at the moment. Having comments immediately visible on the details tab, with latest comment visible is one click less for anyone, no?

Having to scroll down to reach the description (original long form comment) then allows new visitors to read the through the content in a linear fashion before commenting themselves. They can of course just comment without reading any of it, just as now, but placing the description at the bottom shows there is a linear progression

[jancborchardt]

I think it is quite ok. Additionally I would expect activity and comments to be a combined stream as they are both chronological.

Trello also shows activity+comments below the description in the card detail, so it's an established pattern.