feat: Pass on userFacingErrorMessages from chatwithtools task providers - #237
Open
marcelklehr wants to merge 1 commit into
Open
marcelklehr wants to merge 1 commit into
marcelklehr wants to merge 1 commit into
Conversation
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
kyteinsky
reviewed
Sep 15, 2026
Comment on lines
+190
to
+191
| # report_result() cannot send userFacingErrorMessage, so we call the endpoint ourselves. | ||
| # Nextcloud < 33 ignores the extra parameter. |
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
ah, I still had an outdated dependency of nc_py_api
Comment on lines
+81
to
+88
| def task_failed_error(task: Task) -> UserFacingError: | ||
| """Turn a failed sub-task into an error that passes the provider's user-facing message on.""" | ||
| if task.userFacingErrorMessage: | ||
| return UserFacingError( | ||
| f"Nextcloud TaskProcessing Task failed: {task.userFacingErrorMessage}", | ||
| task.userFacingErrorMessage, | ||
| ) | ||
| return UserFacingError("Nextcloud TaskProcessing Task failed") |
Contributor
There was a problem hiding this comment.
maybe it can extended to accept a admin message + user-side?
or are the Exceptions caught somewhere (I couldn't quite pin where the result is reported)?
it would be nice to report the admin error messages generated in context_agent too.
Member
Author
There was a problem hiding this comment.
Mh, as a consumer of task processing we don't have access to the admin-only errors :S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)