fix(assistant): use extended markdown for all NcRichText (renders tables)#613
Merged
Merged
Conversation
Chat messages used use-markdown (CommonMark), so GFM tables did not render. Enable use-extended-markdown on the chat NcRichText so tables and code highlighting render. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Dick Tump <dick@tump.me>
Member
|
Sounds good, let's do it! You can delete |
…ant use-markdown use-extended-markdown already enables markdown rendering, so drop the now-redundant use-markdown and switch every remaining use-markdown usage to use-extended-markdown for uniform GFM rendering, per review. Covers the chat message and reasoning content, the TextInput output, and ContextChatSource. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Dick Tump <dick@tump.me>
dtump
changed the title
Contributor
Author
|
Awesome! And thx for the feedback. I (+ Claude 😄) added the commit addressing your feedback, I think this should be sufficient? |
janepie
self-requested a review
July 23, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat messages are rendered in markdown mode, not extended markdown, so tables aren't rendered. I'm not sure if this is what others want, but AI often outputs tables and, in my opinion, users expect those tables to render correctly. At least that's what I'd like to see, so if others agree, I propose switching to extended markdown. This complements #540 (which left tables out) and also addresses #497. Tested on NC 33 / Assistant 3.5.0. I verified that both a Markdown table and a code block (with syntax highlighting) now render correctly.
Disclosure: I used AI assistance (Claude Code) to locate the relevant prop and prepare this change; I reviewed and tested it myself.
Update (per review): dropped the now-redundant use-markdown and switched all NcRichText usages to use-extended-markdown for uniformity, so this also covers the reasoning content, the "Work with text" output, and ContextChatSource (finishing the tables part #540 left out).
Proof that after this change it correctly renders tables and code blocks: