feat: improve tablet and large-screen navigation layout#16764
feat: improve tablet and large-screen navigation layout#16764mykh-hailo wants to merge 1 commit intonextcloud:masterfrom
Conversation
|
@alperozturk96 Could you please check my PR for the tablet view? |
cef7b13 to
a15915f
Compare
There was a problem hiding this comment.
Hello, thank you for your PR.
Since these changes affect multiple screens, they will require thorough testing. To help the review process, could you please limit the scope to a single screen with minimal changes for now? Once that is reviewed and validated, we can proceed incrementally.
Additionally, please:
- Exclude any
.salivefiles from the PR (I updated gitignore) - Remove comments that restate obvious information (e.g., field descriptions that are self-explanatory)
- Follow camelCase naming conventions (e.g.,
sidebarQuotaViewinstead ofmSidebarQuotaView)
Thanks again for your contribution.
|
@alperozturk96 Thank you for the updates. I initially tired to create a patch that only affects Could you advise on a simpler way to handle this so it's easier to test? |
81352c5 to
fbbf0c4
Compare
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
4136dae to
97bafb0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@alperozturk96 I'd appreciate it if I can continue to work this issue. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@alperozturk96 Can you provide me any updates on this issue? |
|
@tobiasKaminsky Could you please share your feedback? |
Summary
This change adapts the main file browser and several activities for tablets and wide layouts (typically sw600dp / w600dp) by using a persistent navigation column next to content instead of relying only on the sliding DrawerLayout pattern used on phones.
Closes: #14871
DrawerActivity is updated so drawer behavior works when the root layout is not a DrawerLayout (e.g. ConstraintLayout with a fixed-width nav region). Alternative layouts under layout-sw600dp align Compose, Navigator, Contacts preferences, Synced folders, and Upload list with the same idea. files.xml is refactored to support the sidebar + content structure and to keep ViewBinding (FilesBinding / drawer_menu) consistent. TrashbinActivity and toolbar_standard are adjusted for the new structure. New sidebar.xml and resource tweaks (bools, dims) support the tablet configuration.
Technical notes
DrawerActivity: Centralizes “menu layout” handling; drawer toggle, ActionBarDrawerToggle, and related APIs run only when the root is aDrawerLayout; optional hamburger visibility when the layout does not use a sliding drawer.files.xml+sidebar.xmlstructure;FileDisplayActivityupdated as needed for binding / initialization.