Draft
Conversation
# CHANGELOG.md # app/schemas/com.nextcloud.client.database.NextcloudDatabase/66.json # app/src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.java # app/src/main/java/com/owncloud/android/ui/preview/PreviewVideoActivity.kt # app/src/main/res/values-b+en+001/strings.xml # app/src/main/res/values-bg-rBG/strings.xml # app/src/main/res/values-cs-rCZ/strings.xml # app/src/main/res/values-da/strings.xml # app/src/main/res/values-de/strings.xml # app/src/main/res/values-es/strings.xml # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-hu-rHU/strings.xml # app/src/main/res/values-pl/strings.xml # app/src/main/res/values-tr/strings.xml # app/src/main/res/values-zh-rCN/strings.xml # app/src/main/res/values-zh-rHK/strings.xml # app/src/main/res/values-zh-rTW/strings.xml # app/src/main/res/values/strings.xml Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #11278 +/- ##
============================================
+ Coverage 31.44% 31.52% +0.07%
- Complexity 3413 3427 +14
============================================
Files 575 577 +2
Lines 42018 42146 +128
Branches 5660 5664 +4
============================================
+ Hits 13214 13286 +72
- Misses 26861 26905 +44
- Partials 1943 1955 +12
|
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
AlvaroBrey
requested changes
Jan 23, 2023
Member
AlvaroBrey
left a comment
AlvaroBrey
left a comment
There was a problem hiding this comment.
I haven't tested this yet, especially to see how this will behave with existing autoupload folders. This can't be tested without adressing my first comment below, however.
Having said that, this looks quite promising! Thanks for contributing @BatPio
Member
|
@tobiasKaminsky @alperozturk96 @ZetaTom could you give this a review? :) |
Member
|
Will review tomorrow |
…ified-master-v2 # Conflicts: # app/schemas/com.nextcloud.client.database.NextcloudDatabase/89.json
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
# Conflicts: # app/schemas/com.nextcloud.client.database.NextcloudDatabase/90.json # app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt
Signed-off-by: batpio <prbator@gmail.com>
# Conflicts: # app/src/main/java/com/owncloud/android/ui/dialog/SyncedFolderPreferencesDialogFragment.kt
…ation-fixes # Conflicts: # app/src/androidTest/java/com/nextcloud/client/SyncedFoldersActivityIT.java # app/src/main/java/com/owncloud/android/datamodel/FilesystemDataProvider.java
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
BatPio
commented
Aug 8, 2025
| // -> Rest of this file check takes not even 1 ms. | ||
| filesystemDataProvider.storeOrUpdateFileValue(contentPath, | ||
| cursor.getLong(column_index_date_modified), isFolder, | ||
| cursor.getLong(column_index_date_modified) * 1000, |
Author
There was a problem hiding this comment.
In all other places storeOrUpdateFileValue is called with milliseconds, but DATE_MODIFIED stores timestamp in seconds format
https://developer.android.com/reference/android/provider/MediaStore.MediaColumns#DATE_MODIFIED
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
Author
Hi, I updated my branch to master and resolved the conflicts with the database version. Could you please do a review? |
…ified-master-v2-utom-2 # Conflicts: # app/schemas/com.nextcloud.client.database.NextcloudDatabase/91.json # app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt # app/src/main/java/com/nextcloud/client/jobs/FilesSyncWork.kt # app/src/main/java/com/owncloud/android/datamodel/FilesystemDataProvider.java # app/src/main/java/com/owncloud/android/db/ProviderMeta.java
…ation-simplified-master-v2-utom-2 # Conflicts: # app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt # app/src/main/java/com/owncloud/android/db/ProviderMeta.java # app/src/main/java/com/owncloud/android/utils/FilesSyncHelper.java
Signed-off-by: batpio <prbator@gmail.com>
Signed-off-by: batpio <prbator@gmail.com>
…ified-master-v2 # Conflicts: # app/schemas/com.nextcloud.client.database.NextcloudDatabase/97.json # app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt # app/src/main/java/com/owncloud/android/datamodel/SyncedFolderProvider.java # app/src/main/java/com/owncloud/android/db/ProviderMeta.java
Signed-off-by: batpio <prbator@gmail.com>
…ified-master-v2 # Conflicts: # app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt # app/src/main/java/com/owncloud/android/db/ProviderMeta.java
Signed-off-by: batpio <prbator@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7815
Fixes #2323
Some tests are written. I'm waiting for suggestions on what else can be tested.
Delay configuration: