fix(uploader): preserve batch upload destination across navigation#2128
Open
joshtrichards wants to merge 2 commits into
Open
fix(uploader): preserve batch upload destination across navigation#2128joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Snapshot the uploader root when batchUpload starts and pass it through recursive directory and file uploads. This prevents a shared uploader destination change from redirecting remaining files in an active batch. Should fix: nextcloud/server#58352 Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up while looking into nextcloud/server#58352 (which was partially / fully addressed indirectly by not using `batchUpload() any longer in nextcloud/server#60519)
Summary
Snapshot the uploader root when
batchUpload()starts and propagate it through recursive directory and file uploads.This prevents a shared uploader destination change—for example, when a user navigates to another folder—from redirecting files that are already part of an active batch upload.
Changes
This aligns
batchUpload()with the explicit-root behavior already used by the Files app’s external drop handling:https://github.com/nextcloud/server/blob/master/apps/files/src/services/DropService.ts#L139
🤖 AI (if applicable)