Skip to content

fix(auth): allow-list the real profile/* public routes (were people/*) - #8

Open
LilianaTS wants to merge 1 commit into
netuno-org:mainfrom
LilianaTS:fix/allow-list-profile
Open

fix(auth): allow-list the real profile/* public routes (were people/*)#8
LilianaTS wants to merge 1 commit into
netuno-org:mainfrom
LilianaTS:fix/allow-list-profile

Conversation

@LilianaTS

Copy link
Copy Markdown

Problem

The public allow-list in server/core/_service_config.js references routes that do not exist:

if (_service.path === 'people/avatar/get'
  || _service.path === 'people/post'
  || _service.path === 'people/options'
  ...

There is no people/ service directory. The real public routes live under profile/:

  • server/services/profile/avatar/get.js
  • server/services/profile/post.js

The website confirms this — it calls /profile/avatar (multiple call sites) and POST profile (the Register page uses url: 'profile'). Nothing calls people/*.

In development, _service.allow() is called unconditionally, so this is masked. In production, where that blanket allow is gone, public registration and avatar are never allow-listed under their real paths and would be denied.

Fix

Point the allow-list entries at the real routes: profile/avatar/get, profile/post, profile/options.

Copilot AI lite review requested due to automatic review settings September 1, 2026 22:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, low-risk correction that aligns the production allow-list with existing, actively-used service routes.

Pull request overview

Updates the public service allow-list to match the actual profile/* service routes used by the website and present in server/services/profile/**, preventing registration and avatar fetching from being denied in production.

Changes:

  • Replace non-existent people/* allow-list entries with the real profile/avatar/get, profile/post, and profile/options routes in the public allow-list.
File summaries
File Description
server/core/_service_config.js Fixes public allow-list route strings to align with existing profile/* services used for registration and avatar retrieval.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

The public allow-list in server/core/_service_config.js referenced
people/avatar/get, people/post and people/options, but there is no
people/ service directory. The real public routes live under profile/
(profile/avatar/get.js, profile/post.js), and the website calls
/profile/avatar and POST profile. In production (where dev no longer
allows everything) registration and avatar were never allow-listed
under their real paths and would be denied.
@LilianaTS
LilianaTS force-pushed the fix/allow-list-profile branch from 6bffd9c to 7f99133 Compare September 1, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants