fix(auth): allow-list the real profile/* public routes (were people/*) - #8
Open
LilianaTS wants to merge 1 commit into
Open
fix(auth): allow-list the real profile/* public routes (were people/*)#8LilianaTS wants to merge 1 commit into
LilianaTS wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, low-risk correction that aligns the production allow-list with existing, actively-used service routes.
Pull request overview
Updates the public service allow-list to match the actual profile/* service routes used by the website and present in server/services/profile/**, preventing registration and avatar fetching from being denied in production.
Changes:
- Replace non-existent
people/*allow-list entries with the realprofile/avatar/get,profile/post, andprofile/optionsroutes in the public allow-list.
File summaries
| File | Description |
|---|---|
server/core/_service_config.js |
Fixes public allow-list route strings to align with existing profile/* services used for registration and avatar retrieval. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The public allow-list in server/core/_service_config.js referenced people/avatar/get, people/post and people/options, but there is no people/ service directory. The real public routes live under profile/ (profile/avatar/get.js, profile/post.js), and the website calls /profile/avatar and POST profile. In production (where dev no longer allows everything) registration and avatar were never allow-listed under their real paths and would be denied.
LilianaTS
force-pushed
the
fix/allow-list-profile
branch
from
September 1, 2026 22:05
6bffd9c to
7f99133
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public allow-list in
server/core/_service_config.jsreferences routes that do not exist:There is no
people/service directory. The real public routes live underprofile/:server/services/profile/avatar/get.jsserver/services/profile/post.jsThe website confirms this — it calls
/profile/avatar(multiple call sites) andPOST profile(the Register page usesurl: 'profile'). Nothing callspeople/*.In development,
_service.allow()is called unconditionally, so this is masked. In production, where that blanket allow is gone, public registration and avatar are never allow-listed under their real paths and would be denied.Fix
Point the allow-list entries at the real routes:
profile/avatar/get,profile/post,profile/options.