For number type, use a user-defined validation text instead of "Please enter a valid value."#138
Open
Piskvor wants to merge 1 commit into
Open
For number type, use a user-defined validation text instead of "Please enter a valid value."#138Piskvor wants to merge 1 commit into
Piskvor wants to merge 1 commit into
Conversation
The JS library always uses a hardcoded error text if a type="number" field is misfilled. It should only fall back to the hardcoded text if no error message has been defined.
dg
force-pushed
the
master
branch
2 times, most recently
from
January 4, 2017 14:16
5f19501 to
105a1af
Compare
dg
force-pushed
the
master
branch
14 times, most recently
from
January 30, 2017 00:54
a6ec22a to
c2c4dc3
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 2, 2017 03:03
454e643 to
a8c2e65
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
March 29, 2017 16:48
571b36c to
841e5de
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
July 14, 2017 10:58
8ed13d7 to
d6aa86e
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
July 24, 2017 14:08
f1a8ed2 to
b10e0c0
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 11, 2019 11:33
2df07d6 to
82e9980
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
July 8, 2019 09:58
4876961 to
b8d3a7c
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
November 19, 2019 15:43
41ff307 to
f03a237
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
December 11, 2019 19:43
341ed9a to
97e6400
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
January 2, 2020 16:48
9d62255 to
ec59537
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
March 9, 2020 10:42
21f7326 to
35f9b84
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
March 29, 2020 13:47
dc0cb8f to
dd11397
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
May 15, 2020 10:07
dd9d4ef to
458607d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
June 5, 2020 13:20
9c1d9cf to
12d238b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS library always uses a hardcoded error text: "Please enter a valid value." if a type="number" field is misfilled.
It should only fall back to the hardcoded text if no error message has been defined.